Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add compiler error for near set to title with constant near #1100

Merged
merged 2 commits into from
Mar 28, 2023
Merged

add compiler error for near set to title with constant near #1100

merged 2 commits into from
Mar 28, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Mar 28, 2023 •
edited
Loading

Summary

Fixes an issue where a near could be set to a title object.

Details

  • title objects (with a constant near value) are separate from everything else so there shouldn't be a near to them
  • adds compiler test for this scenario

@gavin-ts gavin-ts requested a review from alixander March 28, 2023 18:35
@gavin-ts gavin-ts force-pushed the near-near-const-compile-err branch from e846d28 to 2fd58ec Compare March 28, 2023 18:36
@gavin-ts gavin-ts force-pushed the near-near-const-compile-err branch from 2fd58ec to ad2e3af Compare March 28, 2023 18:37
@gavin-ts gavin-ts enabled auto-merge March 28, 2023 18:43
@gavin-ts gavin-ts merged commit a02fc36 into terrastruct:master Mar 28, 2023
@chenrui333 chenrui333 mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavin-ts @alixander