Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust arrowhead scaling #1101

Merged
merged 4 commits into from
Mar 30, 2023
Merged

adjust arrowhead scaling #1101

merged 4 commits into from
Mar 30, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Mar 29, 2023 •
edited
Loading

Summary

Adjust arrowhead scaling relative to stroke width.

Details

arrowhead_adjustment test before/after

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html (2)

old arrowhead_scaling test

_Users_gavinnishizawa_github_repos_d2_e2etests_testdata_stable_arrowhead_scaling_dagre_sketch exp svg (2)

new arrowhead_scaling test

_Users_gavinnishizawa_github_repos_d2_e2etests_testdata_stable_arrowhead_scaling_dagre_sketch got svg (2)

@gavin-ts gavin-ts marked this pull request as ready for review March 29, 2023 02:58
@gavin-ts gavin-ts requested a review from a team March 29, 2023 02:58
alixander
alixander requested changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

d2renderers/d2svg/d2svg.go Outdated Show resolved Hide resolved
@gavin-ts gavin-ts force-pushed the arrowhead-scaling branch from c4ecd68 to 4d9da42 Compare March 30, 2023 02:57
@gavin-ts gavin-ts force-pushed the arrowhead-scaling branch from 4d9da42 to 91810ea Compare March 30, 2023 03:16
@gavin-ts gavin-ts requested a review from alixander March 30, 2023 03:17
@gavin-ts
Copy link
Contributor Author

rebased and updated values once more

@gavin-ts gavin-ts enabled auto-merge March 30, 2023 03:17
@gavin-ts gavin-ts merged commit cc89394 into terrastruct:master Mar 30, 2023
@chenrui333 chenrui333 mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander Awaiting requested review from alixander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

render: fix arrowhead scaling
2 participants
@gavin-ts @alixander