Lifeline should inherit the stroke style from the actor

[alexstoick]

Fixes #1137

Screenshots

[gavin-ts]

looks good to me

[gavin-ts]

#557 (comment) strikes again

[alixander]

i'm thinking maybe stroke width should never affect the line. @alexstoick do you think that's something people would actually want? i suspect more often than not, they want to change the actor stroke width without line changes.

[alexstoick]

@alixander - Personally, I'm looking for a way to highlight a particular actor in a sequence diagram. Changing the lifeline color (via stroke) - is a feature I'd want.

Another completly different way of tackling this would be to allow the actor to be part of a group - and then it'd be easy to highlight as I could change the group fill.

This can look a bit questionable as it could start overlapping labels / arrows etc - but if we decide not to change the lifeline color this would be an option.

LMK thoughts!

[alixander]

@alexstoick

Changing the lifeline color (via stroke)

yeah for sure, but what about stroke width? i say we should have edges inherit a very small set of attributes from its actor.

• stroke
• stroke-dash

[alexstoick]

@alixander - sorry; I misread your comment. I think tentatively I will say I'm OK with not inheriting the stroke-width - but I can see a scenario where it might be desirable, again for highlighting a particular life line.

[alixander]

yeah we can see how well color serves for that purpose, and if there's requests for stroke-width too, we can add it later

[alexstoick]

OK - I will remove the stroke-width from the PR. Anything else outstanding?

(I'm resolving the signed commit as per Gavin's comment).

[alixander]

nope! looks good to me

[alexstoick]

Should be all resolved now :) Thanks for your comments 🙇

Should I edit the CHANGELOG or is that something you guys manage?

[alixander]

please do! @alexstoick

[alexstoick]

@alixander - CHANGELOG updated ✅

[alixander]

🚀 🙏