Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes: add dark terrastruct flagship theme #1194

Merged

Conversation

berniexie
Copy link
Contributor

@berniexie berniexie commented Apr 13, 2023

Closes #1150

demo

@berniexie berniexie requested review from alixander and a team April 13, 2023 18:11
@berniexie berniexie marked this pull request as ready for review April 13, 2023 18:12
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep dark themes in the same band of IDs.

func (t *Theme) IsDark() bool {

ci/release/changelogs/next.md Show resolved Hide resolved
ci/release/changelogs/next.md Outdated Show resolved Hide resolved
@berniexie berniexie merged commit 1dcf5ee into terrastruct:master Apr 14, 2023
@berniexie berniexie deleted the 1150/dark-terrastruct-flagship-theme branch April 14, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dark mode version of "flagship terrastruct" and "default" themes
2 participants