Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor d2graph.Attributes #1198

Merged
merged 2 commits into from
Apr 15, 2023
Merged

refactor d2graph.Attributes #1198

merged 2 commits into from
Apr 15, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Apr 14, 2023 •
edited
Loading

Summary

Refactoring d2graph.Attributes.

Details

  • move .LabelDimensions in d2graph.Object and d2graph.Edge into d2graph.Attributes.
  • make Attributes embedded in d2graph.Object and d2graph.Edge
  • rename Width *Scalar to WidthAttr *Scalar to fix conflict with d2graph.Object's embedded geo.Box.Width
  • will use Attributes.LabelDimensions for Edge.SrcArrowhead/ DstArrowhead in follow up for render: measure arrowhead label text #183

@gavin-ts gavin-ts marked this pull request as ready for review April 14, 2023 03:31
@gavin-ts gavin-ts requested a review from a team April 14, 2023 03:31
@gavin-ts gavin-ts merged commit a786986 into terrastruct:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavin-ts @alixander