Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gif panic #1257

Merged
merged 3 commits into from
Apr 28, 2023
Merged

gif panic #1257

merged 3 commits into from
Apr 28, 2023

Conversation

alixander
Copy link
Collaborator

@alixander alixander commented Apr 28, 2023 •
edited by ejulio-ts
Loading

closes #1238

xgif was assuming that there would always be 256 colors after quantization.
However, NumColors is just a max and not the exact value after all.
So, if there're < 256 colors, add the white background at the end.
Otherwise, search for the whitest color in the palette and make it full white for background

@alixander alixander marked this pull request as draft April 28, 2023 01:49
@ejulio-ts ejulio-ts marked this pull request as ready for review April 28, 2023 22:00
@ejulio-ts ejulio-ts requested a review from gavin-ts April 28, 2023 22:00
@ejulio-ts
Copy link
Contributor

@alixander I can't ask you to be a reviewer in your own PR 😂

@alixander alixander merged commit 7465823 into terrastruct:master Apr 28, 2023
@alixander alixander deleted the gif-panic branch April 28, 2023 22:11
@alixander alixander changed the title wip: gif panic gif panic Apr 28, 2023
@Porkepix Porkepix mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-ts gavin-ts Awaiting requested review from gavin-ts

Assignees

@ejulio-ts ejulio-ts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: outputting gif
2 participants
@alixander @ejulio-ts