improve grid layout #1263
Merged
improve grid layout #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
approved these changes
Apr 29, 2023
ejulio-ts
reviewed
May 6, 2023
| // skip options with a row that is 1.2*longer or shorter | ||
| // Note: we want a low threshold to explore good options within attemptLimit, | ||
| // but the best option may require a few rows that are far from the target size. | ||
| okThreshold := 1.2 |
| // but the best option may require a few rows that are far from the target size. | ||
| okThreshold := 1.2 | ||
| // if we don't find a layout try 25% larger threshold | ||
| thresholdStep := 0.25 |
There was a problem hiding this comment.
I think the convention is to have this as a constant
| var bestLayout [][]*d2graph.Object | ||
| bestDist := math.MaxFloat64 | ||
| count := 0 | ||
| attemptLimit := 100_000 |
| divisions = append(divisions, append(inner, index-1)) | ||
| } | ||
| iterDivisions(objects[:index], nCuts-1, func(inner []int) bool { | ||
| done = f(append(inner, index-1)) |
There was a problem hiding this comment.
I wonder if these could end up with those issues of slice references since you're expanding it recursively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves performance of grid layout with many objects and rows/columns, and improves even expanding of smaller objects in grid layout.
Details
./ci/e2ereport.shwith-memprofileor-vbeing ineffective due to empty cpuprofile argument before itnew slow_grid test
new grid_oom test (with improved object scaling)
new grid_even test
grid_oom test before improving object scaling
previously the smallest node
ewould grow first becoming larger thancanddnow these are scaled evenly