layout with nested grids

[gavin-ts]

Summary

Updating layout to support nested layouts within grids.

Details

• allow containers for grid cells
• allow grids within grid cells
• adds grid_nested test

new test

[alixander]

1. i feel like grid-gap should apply to the padding? i'm thinking of this guy's use case: markdown: Tables #160 (comment) . or maybe nested grid just has 0 padding. (though nested container still does)

2. do we still have to prevent edges when a grid cell is a container for a non-grid?

[alixander]

1. i feel like grid-gap should apply to the padding? i'm thinking of this guy's use case: markdown: Tables #160 (comment) . or maybe nested grid just has 0 padding. (though nested container still does)

2. do we still have to prevent edges when a grid cell is a container for a non-grid?

[gavin-ts]

1. i feel like grid-gap should apply to the padding? i'm thinking of this guy's use case: markdown: Tables #160 (comment) . or maybe nested grid just has 0 padding. (though nested container still does)

I was thinking we could add container padding customization, but in its own PR. We will probably have to make labels have priority though, otherwise there's no place for them in nested containers with padding 0.

The linked use case has labels and padding around each table. https://github.com/jfudickar/json2puml/blob/main/documentation/images/rocket/rocket_5e9d0d95eda69973a809d1ec.default.svg

Is there a bug here with the order? is last supposed to be at the end? what's the d2?

2. do we still have to prevent edges when a grid cell is a container for a non-grid?

currently yes, but I want to follow up with a refactoring of all of our different layout types (constant nears, sequence diagram, grid, + default) with this refactor, edges within a container in a grid cell would be fine as would a sequence diagram in a grid cell.

[alixander]

no bug. was just demonstrating the padding

The Universe: {
  grid-rows: 3

  FirstTwo.width: 300
  Last.style.fill: red

  TALA: "" {
    grid-rows: 3
    grid-gap: 0
    TALA
    D2
    Cloud
  }
  D2
  Cloud
  Terrastruct.width: 400
}

[gavin-ts]

no bug. was just demonstrating the padding

The Universe: {
  grid-rows: 3
  grid-gap: 0
 ...

ok you can add this^, but yes container padding still exists

[gavin-ts]

okay updated grid layout to also use gap values for container padding and added a test:

e2e delta

[alixander]

only lightly reviewed