Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fonts: fix subset cmap table length #1356

Merged
merged 7 commits into from
Jun 1, 2023

Conversation

berniexie
Copy link
Contributor

@berniexie berniexie commented May 31, 2023

The CMAP length calculation was incorrect. I recalculate it based on how the original fpdf calculates it instead. Thanks to @mikeday for pointing us in the right direction.

Export before fix
broken

Rendered on Prince
Screenshot 2023-05-31 at 4 32 02 PM

Export after fix
fixed

Rendered on Prince
Screenshot 2023-05-31 at 4 32 58 PM

Bernard Xie added 2 commits May 31, 2023 16:30
@berniexie berniexie linked an issue Jun 1, 2023 that may be closed by this pull request
@berniexie berniexie requested review from alixander and a team June 1, 2023 01:47
@berniexie berniexie marked this pull request as ready for review June 1, 2023 01:47
@berniexie berniexie merged commit b87cf74 into terrastruct:master Jun 1, 2023
@berniexie berniexie deleted the bernie/1252/subset-cmap branch June 1, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fonts sometimes have an incorrect cmap subtable
2 participants