Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple edges across nested diagrams #1631

Merged
merged 21 commits into from
Oct 2, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Sep 28, 2023

Summary

Edges can now be created across different nested diagram types and grid cells.

Details

  • follow up to nested edges within grid cells #1629 which supports nested edges and therefore more types of nesting
  • review after nested edges within grid cells #1629 to see only this PR's changes
  • updates nested layout to implement simple edge routing across different nested graph types
  • edges between grid cells of different grids, or descendants of different grid cells are now supported
  • edges into a constant near or sequence diagram are now also supported
  • adds grid_edge_across_cell test
  • adds nesting_power test making use of Redesign nested layout #1602's new design to implement these edges across-nested graph types
  • TODO eventually replace simple straight-edge routing with improved routing to avoid overlaps

edges between descendants of different grid cells are now supported

Screenshot 2023-09-28 at 1 48 47 PM

nesting_power test showing edges across nested diagrams (green)

Screenshot 2023-09-28 at 6 31 22 PM

@gavin-ts gavin-ts force-pushed the simple_edges_across_diagrams branch 3 times, most recently from f8d4d71 to 390737a Compare September 29, 2023 03:09
@gavin-ts gavin-ts requested a review from alixander September 29, 2023 03:12
@gavin-ts gavin-ts marked this pull request as ready for review September 29, 2023 03:12
@gavin-ts gavin-ts force-pushed the simple_edges_across_diagrams branch from 0131c6b to 501f44b Compare October 2, 2023 18:05
@gavin-ts gavin-ts merged commit c49bc8e into terrastruct:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants