Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shapes: limit oval aspect ratio #807

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

gavin-ts
Copy link
Contributor

Summary

Prevent ovals from becoming too flat by limiting their aspect ratio.

Details

  • limit width:height & height:width ratios to 3
  • adds ovals e2e test to see ovals of various widths

ovals before/after

Screen Shot 2023-02-13 at 11 26 14 AM

@gavin-ts gavin-ts marked this pull request as ready for review February 13, 2023 19:30
@gavin-ts gavin-ts requested a review from a team February 13, 2023 19:30
@gavin-ts gavin-ts enabled auto-merge February 13, 2023 19:31
@gavin-ts gavin-ts merged commit 305ed09 into terrastruct:master Feb 13, 2023
@gavin-ts gavin-ts linked an issue Feb 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ovals need better aspect ratio
2 participants