Add playwright deps to arm64 docker image #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nhooyr
commented
Feb 27, 2023
nhooyr
commented
- docker: Install playwright dependencies on arm64
- docker: Build images cross platform natively
Also changed our code to only install chromium. Closes terrastruct#835
|
what is this for again? |
Playwright deps don't install when running under QEMU.
nhooyr
force-pushed
the
docker-arm64-playwright-e161
branch
from
501f433
to
79eac42
Compare
|
@alixander the arm64 d2 container can't compile pngs right now. playwright recently added support for arm64 so I'm just propagating that here as before we had only amd64 whitelisted. I also changed the code to only install chromium and not also firefox/webkit. |
|
See #835 |
alixander
approved these changes
Feb 27, 2023
|
Cool tested and things are working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.