cli: Improve multiboard output #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
force-pushed
the
layers-containers-97eb
branch
3 times, most recently
from
e36efc9
to
c86f0c0
Compare
- Boards with subboards are now selfcontained folders with index.svg/png as the root board render. - Boards that are only containers of other boards are not rendered. For example a scenario with no modifications and only steps only has its steps rendered. - Boards with sibling boards of another type are rendered under a subdirectory indicating their type to separate them. For example a board with layers and scenarios has its layers rendered into subfolder layers and scenarios into subfolder scenarios. cc @berniexie see BoardContainer field on d2target.Board for the field you were looking for to skip renders for PDFs too.
nhooyr
force-pushed
the
layers-containers-97eb
branch
from
5dabe15
to
a73614d
Compare
alixander
requested changes
Feb 27, 2023
alixander
reviewed
Feb 27, 2023
nhooyr
force-pushed
the
layers-containers-97eb
branch
from
06b3bc5
to
73bd684
Compare
As discussed on slack.
nhooyr
force-pushed
the
layers-containers-97eb
branch
from
73bd684
to
f64b5c0
Compare
alixander
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the root board render.
scenario with no modifications and only steps only has its steps
rendered.
subdirectory indicating their type to separate them. For example a
board with layers and scenarios has its layers rendered into subfolder
layers and scenarios into subfolder scenarios.
cc @berniexie see BoardContainer field on d2target.Board for the field
you were looking for to skip renders for PDFs too.