Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render: fit svgs to top left #954

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Mar 2, 2023

Summary

Fit SVGs anchoring to the top left. SVG would fit to screen and be centered, but this would run into issues when zooming in which also zoomed the "padding". This could cause the diagrams to be shifted right or downwards out of view when zooming in.

Details

before

before.mp4

after

after.mp4

@gavin-ts gavin-ts requested a review from alixander March 2, 2023 01:50
@gavin-ts gavin-ts marked this pull request as ready for review March 2, 2023 01:50
@gavin-ts gavin-ts merged commit 3aaa226 into terrastruct:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

left margin not needed(svg file)
2 participants