Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place person shape labels outside below the shape #960

Merged

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Mar 2, 2023

Summary

Fitting labels within the person shape can lead to awkward sizing, so it seems better to position the person labels outside by default.

Screen Shot 2023-03-02 at 3 19 44 PM

Details

e2ereport changes

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html

@alixander
Copy link
Collaborator

Screen Shot 2023-03-02 at 3 13 16 PM

@gavin-ts
Copy link
Contributor Author

gavin-ts commented Mar 2, 2023

RE

These are testing manually set values.
4 has width manually set to be that wide, and 5 has width and height manually set to those dimensions.

d2/e2etests/stable_test.go

Lines 2181 to 2188 in e2c1f31

1.width: 16
2.width: 64
3.width: 128
4.width: 512
# entering both width and height overrides aspect ratio limit
5.height: 256
5.width: 32

@gavin-ts gavin-ts marked this pull request as ready for review March 2, 2023 23:16
@gavin-ts gavin-ts requested a review from a team March 2, 2023 23:16
@alixander
Copy link
Collaborator

oh i see

@gavin-ts gavin-ts merged commit d9ad4aa into terrastruct:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"person shape" aspect ratio too wide, shape too large.
2 participants