case insensitive reserved keyword matching #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
changed the title
nhooyr
approved these changes
Mar 7, 2023
alixander
force-pushed
the
img-shape-children
branch
from
4b82d25
to
3dc07c2
Compare
alixander
force-pushed
the
img-shape-children
branch
from
3dc07c2
to
60c912c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was an issue where a user defined
Stepsas a child of image shape, and we were treating it case sensitive in some places and case insensitive in others.this change makes d2ir compile the fields to lowercase if it's reserved