SW-6168 Fix up types for Slate editor, attempt to fix issue with first line break from hitting enter key not working #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
We may or may not actually want this, I was able to figure out how to fix this without fixing all the types. This is nice, but the surface area is much larger. |
constanzauanini
approved these changes
Nov 6, 2024
…t line break from hitting enter key not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This did not end up fixing the issue, but might be an improvement we want.
Cleans up the types, gets rid of casting. Implements
SectionElementto contain text and variable elements.I spent a while on this, the main area where the fix is attempted is here, but it still does not seem to work. Even though I can see the values are being fixed (through the console), the Slate editor still does not show the line break.