Fix alias bug #302
Merged
Fix alias bug #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
commented
Aug 25, 2024
| const { mode: aliasMode } = parseAlias(token.$value[i]); | ||
| token.partialAliasOf[i] = aliasOfID; | ||
| const { id: aliasID, mode: aliasMode } = parseAlias(token.$value[i]); | ||
| token.partialAliasOf[i] = aliasID; |
There was a problem hiding this comment.
Reaallllly subtle bug: when using partialAliasOf, we want the immediate alias, not the resolved value. This can lead to incorrect values because you may set up different modes / different triggers for intermediary aliases.
Deploying terrazzo with
|
| Latest commit: |
7365f95
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6d4e115.terrazzo.pages.dev |
| Branch Preview URL: | https://plugin-css-publish.terrazzo.pages.dev |
drwpow
commented
Aug 25, 2024
drwpow
force-pushed
the
plugin-css-publish
branch
from
bcd6373
to
71d900c
Compare
drwpow
commented
Aug 25, 2024
| } | ||
| const aliasOfID = resolveAlias(token.$value[i][property], { tokens, logger, filename, node, src }); | ||
| const { mode: aliasMode } = parseAlias(token.$value[i][property]); | ||
| const { id: aliasID, mode: aliasMode } = parseAlias(token.$value[i][property]); | ||
| token.partialAliasOf[i][property] = aliasID; // also keep the shallow alias here, too! |
There was a problem hiding this comment.
Note to self: I am actually a really big fan of having this parser stay in .js. At a microscopic level, sure, there are a few papercuts. But on a macro level, dealing with “incorrect” data structures and defensive programming are SOOOOO much easier in JS than TS (you basically have to turn types off anyway, because it thinks something can’t be a certain type, unless you type everything as unknown, at which point… why are you using TS?)
drwpow
force-pushed
the
plugin-css-publish
branch
from
71d900c
to
7365f95
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a bug in the aliasing. #299 was close, trying to catch the bug, but didn’t quite get it.
How to Review