Skip to content
Daniel Koch edited this page Mar 28, 2022 · 8 revisions
  • rename webpack.dev.js to wepack.config.js
    • DK: No strong opinion on this, but currently each environment is precisely named and config is somewhat unclear.
  • Is prettier really needed? Can't this be forced/dealed with eslint?
    • DK: No, prettier is different from eslint, see e.g. here
    • Removed it anyway in PR 1, some format opinions are strongly unwanted, e.g. not configurable line breaks in destructured objects.
  • Do we want to have the statemanagment in this template? I'd prefer no.
  • I'd prefer to have no components in this template. No layertree, no drawer, ... just an index.tsx and and App.tsx.
    • App.tsx could include a react-geo MapComponent
    • DK: I see this template also as a template for how to structure components and how to make use of hooks and so on, e.g. for training purposes. Each real-world project should just delete all components it doesn't require (which should be all of the existing ones).
  • I'd prefer to have the "real" template as this repo... and the "creator-script" seperately. From a template I'd expect to check it out. run npm i and npm start and have a running client
    • DK: Agreed, this is exactly what I was thinking of.
    • See first draft here
Clone this wiki locally