[question] workshop tutorial failed

[zuhrasofyan]

Guten Tag!

I followed the workshop instruction (https://terrestris.github.io/react-geo-ws/first-steps/) to bootstrap react-geo based app using create-react-app.
Unfortunately, the app failed miserably when I add react-geo dependency.

 sh: react-scripts: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! my-app@0.1.0 start: `react-scripts start`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the my-app@0.1.0 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

It seems the react-geo is not compatible with the new react (16.4.2) release? I had to lower react and react-dom version to be able to run it. but again, the installation dependency of antd and ol do have another problem when I start the app:

./node_modules/@terrestris/ol-util/src/MapUtil/MapUtil.js
Module parse failed: Unexpected token (153:25)
You may need an appropriate loader to handle this file type.
|    * @return {ol.layer.Layer} The layer.
|    */
|   static getLayerByOlUid = (map, ol_uid) => {
|     const layers = MapUtil.getAllLayers(map);
|     const layer = layers.find((l) => {

So, is the workshop outdated, or there is some correct way to setup react-geo based app that I have not do?

[dnlkoch]

Thanks for your report @zuhrasofyan!

The workshop is indeed a bit outdated and hasn't been tested with the newer versions (especially with the latest release) of react-geo for a while, but should work with the latest react at least.

Could you please check if the workshop is working with version 8 by changing it's version to 8.12.1? Taking a quick glance, this worked for me.

[zuhrasofyan]

The result still the same. But taking from the error message, and after I inspected the react-scripts folder in node_modules, it seems, after I installed react-geo the npm removes some packages including react-scripts. Hence, once I manually install the react-scripts, my application works as usual. (both in v8.12.1 and 9.0.0)

[marcjansen]

Any chance you might dig deeper and fix the root error? Or upgrade the workshop? That would be much appreciated.

[hwbllmnn]

Might be unrelated, but I had a similar phenomenon using npm once. After installing a new package with npm install --save <package>, npm would remove some other packages. Just running npm install again reinstalled them. Perhaps this happens with a certain combination of dependencies?

[zuhrasofyan]

That leaves to the second error message generated by the app:

./node_modules/@terrestris/ol-util/src/MapUtil/MapUtil.js
Module parse failed: Unexpected token (153:25)
You may need an appropriate loader to handle this file type.
    * @return {ol.layer.Layer} The layer.
    */
   static getLayerByOlUid = (map, ol_uid) => {
     const layers = MapUtil.getAllLayers(map);
     const layer = layers.find((l) => {

It only appear when I tried to use react-geo component in v9.0.0. I think that is due to the change in the version release mentioned by @dnlkoch "Breaking changes" of Make use of dedicated util packages

[PeterC66]

I get the same error message when at the Include a react-geo component of the workshop.

I first noticed it when trying to implement react-geo into an existing test react/ node system. Not being able to solve the issue there, I started a new project and followed the workshop instructions exactly - and got the same Module parse error. (I did not get the first error mentioned above.)

I am not very familiar with all the technology and versions. What do I do to get it working?

[marcjansen]

@PeterC66 Since #851 has two ways to workaround this, can this be closed?

[PeterC66]

Yes thanks. From: Marc Jansen Sent: Monday, September 3, 2018 10:22 PM To: terrestris/react-geo Cc: PeterC66 ; Mention Subject: Re: [terrestris/react-geo] [question] workshop tutorial failed (#838) @PeterC66 Since #851 has two ways to workaround this, can this be closed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[KaiVolland]

@zuhrasofyan can this be closed or do you have further problems?

[zuhrasofyan]

Sorry.. Will close the issue now.