Replace utility functions with dedicated npm packages #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlkoch
approved these changes
Jul 13, 2018
jest.config.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| const path = require('path'); | |||
src/index.js
Outdated
| import { UndoUtil } from '@terrestris/base-util'; | ||
| import { UrlUtil } from '@terrestris/base-util'; | ||
| import { WfsFilterUtil } from '@terrestris/ol-util'; | ||
| import { Logger } from '@terrestris/base-util'; |
There was a problem hiding this comment.
I think all util imports should be removed from the index.js since all classes are imported directly from the corresponding util modules anyway.
webpack.common.config.js
Outdated
| @@ -36,5 +36,5 @@ module.exports = { | |||
| test: /\.(ttf|eot|svg)(\?v=[0-9]\.[0-9]\.[0-9])?$/, | |||
| use: 'file-loader' | |||
| }] | |||
| } | |||
| }, | |||
webpack.common.config.js
Outdated
| @@ -36,5 +36,5 @@ module.exports = { | |||
| test: /\.(ttf|eot|svg)(\?v=[0-9]\.[0-9]\.[0-9])?$/, | |||
| use: 'file-loader' | |||
| }] | |||
| } | |||
| }, | |||
| }; | |||
There was a problem hiding this comment.
Not related to this PR, but please add a newline.
| import StringUtil from '../../Util/StringUtil/StringUtil'; | ||
| import AnimateUtil from '../../Util/AnimateUtil/AnimateUtil'; | ||
| import Logger from '../../Util/Logger'; | ||
| import { MapUtil } from '@terrestris/ol-util'; |
There was a problem hiding this comment.
Unsure here, but I think in terms of bundle size it could be smarter to import the classes via the direct path, e.g. @terrestris/ol-util/MapUtil/MapUtil.
Maybe @amir-ba can verify this?
There was a problem hiding this comment.
I would also suggest we stick to the habit of importing through direct paths. at least until we have react-geo in ES6
KaiVolland
reviewed
Jul 16, 2018
package.json
Outdated
| @@ -90,7 +90,7 @@ | |||
| "validator": "10.4.0" | |||
| }, | |||
| "devDependencies": { | |||
| "antd": "3.6.6", | |||
| "antd": "^3.7.0", | |||
package.json
Outdated
| @@ -118,7 +118,7 @@ | |||
| "less": "3.7.1", | |||
| "less-loader": "4.1.0", | |||
| "np": "3.0.4", | |||
| "ol": "4.6.5", | |||
| "ol": "^4.6.5", | |||
jansule
force-pushed
the
utilchanges
branch
2 times, most recently
from
59017e0 to
2a9db93
Compare
dnlkoch
approved these changes
Aug 13, 2018
jest.config.js
Outdated
| @@ -27,5 +27,6 @@ module.exports = { | |||
| 'src/**/*.js', | |||
| '!src/**/*example*.*' | |||
| ], | |||
| coverageDirectory: '<rootDir>/coverage' | |||
| coverageDirectory: '<rootDir>/coverage', | |||
| testURL: 'http://localhost/' | |||
There was a problem hiding this comment.
testURL is already present in the current master and can be removed here.
- Remove everything except TestUtil.js from src/Util/ - update dependencies to corresponding npm packages - update tests
Index.js does not import utility modules anymore. Now, needed utilities will be directly imported within the respective classes. Furthermore, minor changes e.g. removing dangling commas were done.
Due to a minor release of jsdom, jest cannot handle default testURL anymore. testURL now needs to be specified explicitely. Here, localhost was used.
|
Thanks again @jansule! |
hblitza
pushed a commit
that referenced
this pull request
Oct 19, 2022
…29.0.0 chore(deps-dev): bump jest from 28.1.3 to 29.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Description:
Extract utility functions and create dedicated npm packages (@terrestris/base-util, @terrestris/ol-util). Extraction aims at improving reusability of core functions within other projects.
Technically, all files except TestUtil.js were removed from src/Util/. All paths were updated (including *.spec.js) and dependencies to the packages were included.
Further information in this issue.
So far only ES6 version exists.
#762