-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoServer REST importer #285
Conversation
… (temporarily) override the default one
… content & more logs
…sn't available in GeoServer, e.g. for ESRI definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @dnlkoch. I've just added some minor issues only (mostly regarding Javadoc comments)
/*** | ||
* | ||
* @param importerBaseURL | ||
* @param defaultSRS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in b119a96.
|
||
/** | ||
* | ||
* @param importJob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong javadoc parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in b119a96.
* @author terrestris GmbH & Co. KG | ||
* | ||
*/ | ||
public class RESTDataDirectory extends RESTData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this class currently needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, actually not. I would leave it for future purposes, ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright.
* @author terrestris GmbH & Co. KG | ||
* | ||
*/ | ||
public class RESTDataFile extends RESTData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this class currently needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
* @author terrestris GmbH & Co. KG | ||
* | ||
*/ | ||
public class RESTDataRemote extends RESTData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this class currently needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
* @author terrestris GmbH & Co. KG | ||
* | ||
*/ | ||
public class RESTDateFormatTransform extends RESTTransform { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this class currently needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
@@ -193,6 +197,12 @@ | |||
<!-- Apache HTTP Client --> | |||
<apache-httpclient.version>4.5.3</apache-httpclient.version> | |||
|
|||
<!-- GeoTools --> | |||
<geotools.version>17.3</geotools.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this version depend on the used version of GeoServer resp. the used version of the importer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, actually not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more documentation on the properties would be nice.
I'd also prefer to not submit the dummy classes. But my opinion on this is not very strong.
All in all nothing blocking. So feel free to merge.
/** | ||
* | ||
*/ | ||
private URI baseUri; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLz provide some more docs.
Will merge this PR now and create an issue for enhancement of the docs |
This adds the
GeoServerRESTImporter
that can be used to easily call the GeoServer importer extension's REST API.