Fixed service resource context manager exit

Fixes aio-libs/aiobotocore#922
terricain · Mar 12, 2022 · 7dbd51a · 7dbd51a
1 parent 3861949
commit 7dbd51a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/aioboto3/resources/base.py b/aioboto3/resources/base.py
@@ -1,4 +1,5 @@
 import logging
+import warnings
 
 from boto3.resources.base import ServiceResource
 
@@ -10,8 +11,8 @@ async def __aenter__(self):
         return self
 
     async def __aexit__(self, exc_type, exc_val, exc_tb):
-        await self.meta.client.close()
-        return False
+        await self.meta.client.__aexit__(exc_type, exc_val, exc_tb)
 
     def close(self):
+        warnings.warn("This should not be called anymore", DeprecationWarning)
         return self.meta.client.close()
diff --git a/aioboto3/session.py b/aioboto3/session.py
@@ -212,4 +212,4 @@ async def __aenter__(self):
         return self.cls
 
     async def __aexit__(self, exc_type, exc, tb):
-        await self.cls.close()
+        await self.cls.__aexit__(exc_type, exc, tb)