Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrieval context object #26

Merged
merged 52 commits into from
Jul 23, 2024
Merged

retrieval context object #26

merged 52 commits into from
Jul 23, 2024

Conversation

seanmacavaney
Copy link
Collaborator

Save time during retrieval by opening the index ahead of time (rather than re-allocating memory every time).

@seanmacavaney
misc
37340ae
@seanmacavaney
merge
3b0f375
@seanmacavaney
Path vs str
1dd95a1
@seanmacavaney
it's alive
4a651c6
@seanmacavaney
some cleanup
19a3877
@seanmacavaney
misc
4ac9273
@seanmacavaney
Merge branch 'retr_ctxt' of github.com:terrierteam/pyterrier_pisa int…
540387a 
…o retr_ctxt
@seanmacavaney
merge
b545924
@seanmacavaney
merge
3a80532
@seanmacavaney
some cleanup, tests pass
39eea29
@seanmacavaney
cleanup, tests pass
a700ddc
@seanmacavaney
rename
8e65fbd
@seanmacavaney
diagnosing "pure virtual method called" error
43a79aa
@seanmacavaney
trigger build
6cb76f1
@seanmacavaney
it's no longer breaking on GH? Why not?
a97a364
@seanmacavaney
giving up, "pure virtual method called" no longer seems to be an issue?
9d3fb76
@seanmacavaney
rearrange for cleaner diff
de6ac61
@seanmacavaney
restore indent for cleaner diff
a9af4f0
@seanmacavaney
intermittent issue, running each setting 3 times with more logging
83d0b13
@seanmacavaney
free self?
cb7e33a
@seanmacavaney
better error handling on module init
1e7e7a9
@seanmacavaney
generic compile flag?
8642792
@seanmacavaney
better way
64f3b9e
@seanmacavaney
compiler tuning
004e5e8
@seanmacavaney
enable SIMD commands
8e5f6da
@seanmacavaney
more
36b4485
@seanmacavaney
actually this instead?
6f8af73
@seanmacavaney
bam
e28118c
@seanmacavaney
less
cfc4746
@seanmacavaney
PyInit logging
51476a8
@seanmacavaney
Copy link
Collaborator Author

Some tests fail but:

  • It's intermittent
  • I can't reproduce it outside the GH test runner
  • It's only happens when the process is terminating anyway

Let's merge and see what the effect is in practice.

@seanmacavaney seanmacavaney merged commit 8b661bf into main Jul 23, 2024
8 checks passed
@seanmacavaney seanmacavaney deleted the retr_ctxt branch July 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seanmacavaney