Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yannicklin bugfixes and improvements on September 2022 #25

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

yannicklin
Copy link

@yannicklin yannicklin commented Sep 2, 2022

  1. Remove the dependency on jQuery, instead using vanilla javascript
  2. only generate status if debug option is enabled; this would also reduce the HTML raw size a little bit
  3. Add the support of Custom Post Type and its archives
  4. Also swap the error of footer marks (text-ver and icon-ver)
  5. bugfix of url exclusion, enabling even only one line input

yannicklin added 24 commits May 31, 2022 16:17
1. change jQuery to vanilla JS
2. only output the status if debug option is enabled
…into images-fix-and-custom-post-type-improvements
@yannicklin yannicklin changed the title Yannicklin bugfixes and improvements september 2022 Yannicklin bugfixes and improvements on September 2022 Sep 2, 2022
@yannicklin yannicklin marked this pull request as ready for review September 2, 2022 09:27
<input type="checkbox" name="scm_option_post_types[<?php echo $post_type->name; ?>]" id="cache-master-post-type-option-<?php echo $post_type->name; ?>" value="yes" <?php if (isset($option_post_types[$post_type->name])) : ?> <?php checked($option_post_types[$post_type->name], 'yes'); ?> <?php endif; ?>>
<label for="cache-master-post-type-option-<?php echo $post_type->name; ?>">
<?php echo $post_type->labels->singular_name; ?><br />
<label>
Copy link

@swiffer swiffer Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</label> ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha ! You are correct. That's my fault. I would update ti soon.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In actual, I'm thinking to slime down this plugin.

  1. I have no idea what's the situation we need the "expert mode".
  2. Memcache, APC, APCu, WinCache, .... A clear-out of old modules and non-used classes should be to considered...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expert mode is faster from my understanding. Simplification sounds great, however do we know what modules are used how frequently? I wonder why we're not seeing the current MR merged and released, the improvements are warm welcomed here ;)

@swiffer
Copy link

swiffer commented Sep 12, 2022

@terrylinooo sorry for pushing but it would be super great to get the support for custom post types merged and a new version released - any thoughts from your side?

@lukasj98
Copy link

when are the custom post types supported ?

@swiffer
Copy link

swiffer commented May 29, 2023

Hi @terrylinooo - appreciate the latest Update. Would you consider Merging the improvements of this pr when rebased?

@terrylinooo
Copy link
Owner

terrylinooo commented May 29, 2023

Hello, @swiffer , I'll take a look at it and test it carefully, then merge your PR. Thanks for your contributing.

@swiffer
Copy link

swiffer commented Aug 24, 2023

Hi @terrylinooo - did you have a chance to go through the changes? (it's the work of @yannicklin but I'm really looking forward having the functionality available).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants