-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yannicklin bugfixes and improvements on September 2022 #25
base: master
Are you sure you want to change the base?
Yannicklin bugfixes and improvements on September 2022 #25
Conversation
yannicklin
commented
Sep 2, 2022
•
edited
Loading
edited
- Remove the dependency on jQuery, instead using vanilla javascript
- only generate status if debug option is enabled; this would also reduce the HTML raw size a little bit
- Add the support of Custom Post Type and its archives
- Also swap the error of footer marks (text-ver and icon-ver)
- bugfix of url exclusion, enabling even only one line input
1. change jQuery to vanilla JS 2. only output the status if debug option is enabled
…ve-jquery-dependency
…into images-fix-and-custom-post-type-improvements
…//github.com/yannicklin/cache-master into remove-jquery-dependency
…//github.com/yannicklin/cache-master into remove-jquery-dependency
…//github.com/yannicklin/cache-master into remove-jquery-dependency
…//github.com/yannicklin/cache-master into remove-jquery-dependency
…//github.com/yannicklin/cache-master into remove-jquery-dependency
<input type="checkbox" name="scm_option_post_types[<?php echo $post_type->name; ?>]" id="cache-master-post-type-option-<?php echo $post_type->name; ?>" value="yes" <?php if (isset($option_post_types[$post_type->name])) : ?> <?php checked($option_post_types[$post_type->name], 'yes'); ?> <?php endif; ?>> | ||
<label for="cache-master-post-type-option-<?php echo $post_type->name; ?>"> | ||
<?php echo $post_type->labels->singular_name; ?><br /> | ||
<label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</label>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha ! You are correct. That's my fault. I would update ti soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In actual, I'm thinking to slime down this plugin.
- I have no idea what's the situation we need the "expert mode".
- Memcache, APC, APCu, WinCache, .... A clear-out of old modules and non-used classes should be to considered...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expert mode is faster from my understanding. Simplification sounds great, however do we know what modules are used how frequently? I wonder why we're not seeing the current MR merged and released, the improvements are warm welcomed here ;)
@terrylinooo sorry for pushing but it would be super great to get the support for custom post types merged and a new version released - any thoughts from your side? |
when are the custom post types supported ? |
Hi @terrylinooo - appreciate the latest Update. Would you consider Merging the improvements of this pr when rebased? |
Hello, @swiffer , I'll take a look at it and test it carefully, then merge your PR. Thanks for your contributing. |
Hi @terrylinooo - did you have a chance to go through the changes? (it's the work of @yannicklin but I'm really looking forward having the functionality available). |