Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: bring up share function #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

SukkaW
Copy link

@SukkaW SukkaW commented Jul 29, 2022

The PR supersedes #25:

  • Use gzip and js-base64 (url-safe base64 built in) to generate share url
  • Use existing evalConfig instead of a home-baken deserializer

image

@SukkaW
Copy link
Author

SukkaW commented Jul 30, 2023

@fabiosantoscode Kindly request your attention with a friendly ping. My PR has been open for a year. I would greatly appreciate it if you could spare some time to review it, at your convenience, and provide your valuable feedback.

@fabiosantoscode
Copy link
Contributor

I can't really merge this because evalOptions calls eval, making it an XSS risk.

@mariomc
Copy link

mariomc commented Sep 7, 2023

I can't really merge this because evalOptions calls eval, making it an XSS risk.

Any reason to keep using eval? It seems that most options are simple JSON-stringifiable options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants