Fix panic getting timestamp on wasm32-unknown-unknown target
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesaguri
added a commit
to dbw9580/oauth1-request-rs
that referenced
this pull request
Oct 6, 2021
tesaguri
added a commit
to dbw9580/oauth1-request-rs
that referenced
this pull request
Oct 6, 2021
tesaguri
force-pushed
the
fix-wasm-time
branch
from
2c011be to
010f83d
Compare
tesaguri
added a commit
to dbw9580/oauth1-request-rs
that referenced
this pull request
Oct 6, 2021
tesaguri
force-pushed
the
fix-wasm-time
branch
from
010f83d to
da401f2
Compare
tesaguri
added a commit
to dbw9580/oauth1-request-rs
that referenced
this pull request
Oct 6, 2021
tesaguri
force-pushed
the
fix-wasm-time
branch
from
da401f2 to
2e897d8
Compare
tesaguri
added a commit
to dbw9580/oauth1-request-rs
that referenced
this pull request
Oct 6, 2021
tesaguri
force-pushed
the
fix-wasm-time
branch
from
2e897d8 to
ea4c9eb
Compare
tesaguri
force-pushed
the
fix-wasm-time
branch
from
ea4c9eb to
3bc307a
Compare
|
Thank you for the patch! I've put this behind a Cargo feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::time::SystemTime::nowonwasm32-unknown-unknowntarget is not supported and panics. Related discussion.This PR fixes this issue by using
js_sys::Date::nowas a replacement, assuming there's JavaScript environment available at runtime.