Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Charges Dashboard -> Range added renamed to Ø Charge rate #4349

Conversation

swiffer
Copy link
Contributor

@swiffer swiffer commented Nov 3, 2024

fixes #4348 (should be merged on top of #4338, I can rebase after merge)

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit ac8babf
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/672a38fa0e39050008862e4b
😎 Deploy Preview https://deploy-preview-4349--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld added enhancement New feature or request area:dashboard Related to a Grafana dashboard labels Nov 3, 2024
@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Nov 3, 2024

Ty.
It seems like you used your #4338 branch for this pr, so we could be fine if we first merge #4338

@swiffer
Copy link
Contributor Author

swiffer commented Nov 3, 2024

yes 👍

@swiffer swiffer force-pushed the charges-range-added-to-charge-rate branch from 084b201 to fd4f4c4 Compare November 3, 2024 09:58
@JakobLichterfeld
Copy link
Collaborator

@swiffer any idea why it still shows 27 changes after merging #4338 ?

@swiffer
Copy link
Contributor Author

swiffer commented Nov 5, 2024

not rebased yet, one second

@swiffer swiffer force-pushed the charges-range-added-to-charge-rate branch from 7987e5a to ac8babf Compare November 5, 2024 15:25
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, ty.

@JakobLichterfeld
Copy link
Collaborator

Tested successfully.

@JakobLichterfeld JakobLichterfeld merged commit d64f799 into teslamate-org:master Nov 5, 2024
15 checks passed
@swiffer swiffer deleted the charges-range-added-to-charge-rate branch November 5, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Range Added" has incorrect units on the Charges dashboard
2 participants