Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#397: Added playgrounds to doc site #399

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

k2snowman69
Copy link

A few other minor updates other than the title

  • Removed the Rickroll page - It's a bit unprofessional, I'm guessing it was kept from the internal site
  • Fixed some class properties which should have been className there might be more though
  • Fixed spelling of "GlobalForms" to "Global Forms"
  • Added required properties to both playgrounds as I'm sure that's a common request so figured it's good to add it in the playground

Some things that I think some additional guidance would be good

  • I didn't find contributing documentation anywhere so I just guessed what I'm supposed to do

Some things I think need to be investigated

  • The build:docs script fails on windows because rm doesn't exist. I've found rimraf to be useful for cross platformizing this. Not sure if the policy of this repo is "no windows" but it's a simple fix though I'm sure this isn't the only cross platform issue
  • Your lint-staged script runs prettier on all files including your generated doc pages. I had to work around this by rebuilding the doc site and doing a git commit --amend --no-edit which probably isn't the best solution. Not sure if this was intentional though so I didn't create a ticket
  • Styles seem to be a bit broken - I created Styles are broken in website #398 with information

@joepuzzo
Copy link
Collaborator

joepuzzo commented Mar 12, 2022

A few other minor updates other than the title

  • I have had users laugh a lot about the rick roll so im inclined to keep it as it seems to brighten peoples day
  • Awesome thanks!
  • Awesome thanks!
  • Please if you are going to add playgrounds back, use the new sandbox tool ( see example on first page )

Some things that I think some additional guidance would be good

  • I will add

Some things I think need to be investigated

  • 😱 you are using windows!?!?!?!? :trollface:
  • 100% agree I need to ignore docs for linter
  • Styles are not broken, there are no styles for checkboxes and radios 😁 because it sucks to style them. ( remember this does not use our actual tesla styles )

@k2snowman69
Copy link
Author

k2snowman69 commented Mar 13, 2022

A few other minor updates other than the title

  1. DM about this
  2. Done!

Some things I think need to be investigated

  1. Depends what machine, I use linux, osx, and windows. I do this to lower barrier of entry for people attempting to contribute to repos
  2. Leaving that discussion for the currently open ticket (no further updates here)

@joepuzzo joepuzzo merged commit 6d5386d into teslamotors:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants