README: Force use of named curves in example #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS uses LibreSSL for the OpenSSL command, and LibreSSL defaults to using explicit curve parameters rather than named curves when encoding private keys with `openssl req ...`. But the Golang x509 library does not support explicit curve parameters, causing `tesla-http-proxy` to fail with "x509: invalid ECDSA parameters". This commit fixes the problem by adding an option to the openssl command in the README that forces LibreSSL to use named curves.
aaronpkahn
approved these changes
Dec 8, 2023
agbpatro
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS uses LibreSSL for the OpenSSL command, and LibreSSL defaults to using explicit curve parameters rather than named curves when encoding private keys with
openssl req .... But the Golang x509 library does not support explicit curve parameters, causingtesla-http-proxyto fail with "x509: invalid ECDSA parameters".This commit fixes the problem by adding an option to the openssl command in the README that forces LibreSSL to use named curves.
Description
Please include a summary of the changes and the related issue.
Fixes #83
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: