Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 13590: tesseract-ocr/fuzzer-api: Heap-buffer-overflow in GenericVector<int>::size #2298

Closed
stweil opened this issue Mar 8, 2019 · 2 comments
Closed

Issue 13590: tesseract-ocr/fuzzer-api: Heap-buffer-overflow in GenericVector<int>::size #2298

stweil opened this issue Mar 8, 2019 · 2 comments
Labels
bug
Milestone
4.1.1

Comments

@stweil
Copy link
Member

stweil commented Mar 8, 2019

OSS Fuzz reports a security issue.
@stweil stweil added this to the 4.1.0 milestone Mar 8, 2019
@stweil
Copy link
Member Author

stweil commented Mar 10, 2019

This crash happens very often in the fuzzing test. It seems to be caused by Tesseract using the wrong unicharset, so tessdata_best, tessdata_fast and the initial revision of tessdata are not affected. It can occur with traineddata which includes different unicharsets for legacy and LSTM recognizers. The fuzzer uses tessdata/eng.traineddata where eng.lstm-unicharset has 112 entries while eng.unicharset has 113 entries. It tries to get entry 112 which only exists in the legacy unicharset.

Obviously PR #1954 did not fix all code locations.

Related open issue: #1222, #1307, #2301.

stweil added a commit to stweil/tesseract that referenced this issue Mar 10, 2019
@stweil
Fix Heap-buffer-overflow in GenericVector<int>::size (issue tesseract…
b81d6cb 
…-ocr#2298)

Credit to OSS-Fuzz: This fixes an issue which was reported by OSS-Fuzz:

Add also some assertions to catch similar bugs.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
stweil added a commit to stweil/tesseract that referenced this issue Mar 10, 2019
@stweil
Fix Heap-buffer-overflow in GenericVector<int>::size (issue tesseract…
71d4990 
…-ocr#2298)

Credit to OSS-Fuzz:
This fixes a security issue which was reported by OSS-Fuzz, see details at
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13590.

Add also some assertions to catch similar bugs.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
zdenop added a commit that referenced this issue Mar 10, 2019
@zdenop
Merge pull request #2305 from stweil/fuzz
0e72733 
Fix Heap-buffer-overflow in GenericVector<int>::size (issue #2298)
@stweil
Copy link
Member Author

stweil commented Mar 10, 2019

Pull request #2305 fixed this issue.

@stweil stweil closed this as completed Mar 10, 2019
@stweil stweil mentioned this issue Mar 10, 2019
Closed
@stweil stweil added the bug label Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.1.1
Development

No branches or pull requests
1 participant
@stweil