-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version handling #1408
Update version handling #1408
Conversation
ccutil/version.h is now no longer needed. Signed-off-by: Stefan Weil <sw@weilnetz.de>
Will this work also for Visual studio builds? |
Appveyor says yes. Cmake handles the necessary preparations. I cannot test it myself as I don't have Visual Studio. |
So git-rev info is dropped? |
Yes, that's my plan. The current code for autoconf in configure.ac already uses the Git information if it is available (not only for the debug case as the old code did). For CMake, this still needs an implementation which first checks Git and then looks in file |
@zdenop, making a new Tesseract release will require updating and committing the VERSION file, then adding a Git tag with some descriptive text, then describing the new release in GitHub. |
I want this feature: Have a variable What do you think about this proposal? |
I think it is not needed. The git revision is only appended if last tagged revision and current revision differ. It is automatically omitted if you are working on a tagged revision. |
Sounds good, thanks! |
@zdenop, do you have more questions, or can this PR be merged? |
I just wantted to test it. It seems to work with Visual Studio 15 2017 Win64 |
ccutil/version.h is now no longer needed.
Signed-off-by: Stefan Weil sw@weilnetz.de