Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pose vector for collision objects, as CompoundMesh shapes can have multiple collision objects. #1080

Closed

Conversation

rjoomen
Copy link
Contributor

@rjoomen rjoomen commented Dec 11, 2024

Fixes #1053

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.40%. Comparing base (5ad42b6) to head (3181ba2).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
- Coverage   89.40%   89.40%   -0.01%     
==========================================
  Files         288      288              
  Lines       16304    16308       +4     
==========================================
+ Hits        14577    14580       +3     
- Misses       1727     1728       +1     

see 3 files with indirect coverage changes

@Levi-Armstrong
Copy link
Contributor

Ah, I now understand the issue. Do you have a test case that you have been using to add to the unit test frame work? I will take a look at this PR later this week. Thank you for tracking this down.

@rjoomen
Copy link
Contributor Author

rjoomen commented Dec 12, 2024

Ah, I now understand the issue. Do you have a test case that you have been using to add to the unit test frame work? I will take a look at this PR later this week. Thank you for tracking this down.

I don't have a test case, as I used my own production code. But I think adding a setCollisionObjectsTransform call for the CompoundMesh to the existing test case should to the trick.

@rjoomen
Copy link
Contributor Author

rjoomen commented Dec 18, 2024

Replaced by #1083

@rjoomen rjoomen closed this Dec 18, 2024
@rjoomen rjoomen deleted the FixFCLCompoundMesh branch December 19, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompoundMesh does not work with FCL
2 participants