Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change environment getJointGroup and getKinematicGroup to return shared pointers #1092

Conversation

Levi-Armstrong
Copy link
Contributor

This change improves performance in motion planning. Both the JointGroup and KinematicGroup only have const methods so to avoid making duplicate copies they can all share the same object.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.24%. Comparing base (ad309d7) to head (e11d815).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1092      +/-   ##
==========================================
+ Coverage   89.23%   89.24%   +0.01%     
==========================================
  Files         289      289              
  Lines       16380    16377       -3     
==========================================
- Hits        14616    14615       -1     
+ Misses       1764     1762       -2     

see 1 file with indirect coverage changes

@Levi-Armstrong Levi-Armstrong merged commit 5416ec6 into tesseract-robotics:master Jan 2, 2025
13 of 15 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feature/environment-kin-group-return-shared-ptr branch January 2, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant