Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContactAllowedValidator and ContactResultValidator #1095

Conversation

Levi-Armstrong
Copy link
Contributor

@Levi-Armstrong Levi-Armstrong commented Jan 2, 2025

Remove use of function pointers and leverages classes which can be serialized.

@Levi-Armstrong Levi-Armstrong force-pushed the feature/validator-classes branch 2 times, most recently from 302ee29 to 6c68a7a Compare January 4, 2025 00:48
@Levi-Armstrong
Copy link
Contributor Author

Address #1093

@Levi-Armstrong Levi-Armstrong force-pushed the feature/validator-classes branch from 6c68a7a to fca09d0 Compare January 4, 2025 01:31
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (16a4193) to head (97b1c22).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
- Coverage   89.24%   89.05%   -0.19%     
==========================================
  Files         289      294       +5     
  Lines       16377    16432      +55     
==========================================
+ Hits        14615    14633      +18     
- Misses       1762     1799      +37     

see 24 files with indirect coverage changes

@Levi-Armstrong Levi-Armstrong merged commit 11d935b into tesseract-robotics:master Jan 4, 2025
13 of 15 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feature/validator-classes branch January 4, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant