Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed environment benchmark #694

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

marip8
Copy link
Contributor

@marip8 marip8 commented Jan 5, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #694 (e29a770) into master (5e01db6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         172      172           
  Lines       11017    11017           
=======================================
  Hits        10154    10154           
  Misses        863      863           

@Levi-Armstrong
Copy link
Contributor

@marip8 Are you able to trigger the benchmark build on your repo to show it passes? If not and you tested locally feel free to merge.

@marip8
Copy link
Contributor Author

marip8 commented Jan 6, 2022

I built the benchmarks locally and ran the one that I changed, so I'm fairly confident this fixes the issue

@marip8 marip8 merged commit 458e26f into tesseract-robotics:master Jan 6, 2022
@marip8 marip8 deleted the update/benchmark branch January 6, 2022 14:49
@marip8
Copy link
Contributor Author

marip8 commented Jan 6, 2022

It would probably be a good idea to separate the building of benchmarks from the running of them, like we do for unit tests. Then we could build the benchmarks as a part of CI, but only run them when the master branch is changed. That way they will stay up-to-date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants