Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed gcc-specific options from clang config #903

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Removed gcc-specific options from clang config #903

merged 1 commit into from
Jun 14, 2023

Conversation

rjoomen
Copy link
Contributor

@rjoomen rjoomen commented Jun 14, 2023

No description provided.

@Levi-Armstrong
Copy link
Contributor

It is not clear to me why these should or need to be remove?

@rjoomen
Copy link
Contributor Author

rjoomen commented Jun 14, 2023 •
edited
Loading

These two removed warning options are for gcc, and do not exist for clang (see line 34), so they actually produced extra warnings in clangd for me.

@Levi-Armstrong
Copy link
Contributor

Ah, looking at the diff I did not see there were different options for clang and gcc.

@Levi-Armstrong Levi-Armstrong merged commit 43d0887 into tesseract-robotics:master Jun 14, 2023
@rjoomen rjoomen deleted the patch-1 branch June 19, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Levi-Armstrong Levi-Armstrong Levi-Armstrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjoomen @Levi-Armstrong