chore: Fix tests, remove EOL OSes, fix Ruby 3.4 compatibility warnings #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
RulerOf
changed the title
tas50
reviewed
Jul 3, 2024
| driver: | ||
| image: opensuse/leap:15 |
There was a problem hiding this comment.
This slug should get you the latest without having to maintain the version here
There was a problem hiding this comment.
I ended up putting in the two versions separately because both of them showed to still be under active support on the website.
There was a problem hiding this comment.
Oh wait I see what you mean. Specify a "latest v15" in addition to a "specific v15."
There was a problem hiding this comment.
Leap:15 should always be the latest
Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Ruby is removing some gems from the standard library. Require them explicitly. Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Development group gems resolved an old version of inspec on my machine, and would throw an ugly warning. Bump the minimum inspec version to resolve that. Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
CentOS 7 is EOL. Stop testing it, and switch to a similar release. Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Chef is not supported on every OS that kitchen-docker supports, so it doesn't really make sense to install it here. Also Dokken is a thing. Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
The default busser verifier literally refuses to work, and the 1-test inspec is simple enough to work on everything. Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Bundler shims and rubymine folder Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
CentOS 7, Ubuntu 18, Rocky 8, Debian 11 are all EOL. Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Stromweld
requested changes
Jul 3, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM centos:7 | |||
| FROM oraclelinux:7 | |||
There was a problem hiding this comment.
in the kitchen-dokken driver we switched to almalinux-9. Should probably do the same here for consistency and future proofing. Then the yum commands can be updated to dnf.
There was a problem hiding this comment.
I updated the Dockerfile and got it building successfully, but kitchen-docker complains the container isn't listening for ssh connections.
Perhaps I need to change the CMD to run the ssh server? It wasn't obvious to me why it worked with Oracle 7 but not Alma 9.
Signed-off-by: Corey Hemminger <hemminger@hotmail.com> Signed-off-by: Andrew Bobulsky <rulerof@gmail.com> add codeowners Signed-off-by: Corey Hemminger <hemminger@hotmail.com> test Signed-off-by: Corey Hemminger <hemminger@hotmail.com> test Signed-off-by: Corey Hemminger <hemminger@hotmail.com> test Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Everything is already testing with Inspec Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
The verifier doesn't work without it. Not sure why it was removed, but I know base PR was ongoing. Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Add a step to the github action that uses an embedded ruby script to discover the list of suites directly from the kitchen config. Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Do this instead of testing 15.5 and 15.6 explicitly Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Current versions of Docker Desktop will output a LegacyKeyValueFormat warning when using 'ENV key value' syntax. We switch to the updated 'ENV key=value' syntax. Signed-off-by: Andrew Bobulsky <rulerof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most of the tests were broken.
Issues Resolved
I didn't create any, but this will fix the broken tests on #420
Type of Change
chore
Check List