Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require aws_ssh_key_id in ec2.rb #268

Closed
gasserk opened this issue Aug 8, 2016 · 1 comment
Closed

Do not require aws_ssh_key_id in ec2.rb #268

gasserk opened this issue Aug 8, 2016 · 1 comment

Comments

@gasserk
Copy link
Contributor

gasserk commented Aug 8, 2016 •
edited
Loading

Not all enterprise environments at AWS use the AWS Managed Key Service. Recommend not requiring 'aws_ssh_key_id' (as it may be pre-provisioned on the AMI, or managed separately through user_data). Precedent for this is #257 to make the AMI tags optional.
@mwrock mwrock closed this as completed in 49cae45 Aug 23, 2016
mwrock added a commit that referenced this issue Aug 23, 2016
@mwrock
Merge pull request #269 from gasserk/ssh-keys-optional
119001d 
Fix #268
@bclodius
Copy link

@gasserk thanks for this contribution! I really needed this.

@ghost ghost mentioned this issue Mar 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bclodius @gasserk