Adding ohai hints #102
Closed
Adding ohai hints #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-ball
force-pushed
the
tball/ohai-hint
branch
from
0470174
to
eb7501a
Compare
tyler-ball
force-pushed
the
tball/ohai-hint
branch
from
eb7501a
to
8a1f7c5
Compare
| # TODO Update this to use the new Transport logic when that is ready | ||
| def create_ec2_json(state) | ||
| Kitchen::SSH.new(*build_ssh_args(state)) do |conn| | ||
| run_remote("sudo mkdir -p /etc/chef/ohai/hints;sudo touch /etc/chef/ohai/hints/ec2.json", |
There was a problem hiding this comment.
Will sudo always be available? I think we use it elsewhere but I may misremember.
There was a problem hiding this comment.
This is not an ideal fix - when we can leverage the Transport logic from the windows-guest-support branches we will move this logic there. This is just a temporary workaround until we get access to that.
Having said that, do you think I should add a feature flag or something, so people on systems without sudo (or touch) aren't totally borked by this?
|
@tyler-ball Will this need to be reworked to fit in with #109? The only thing making me wonder is the use of |
tyler-ball
added a commit
that referenced
this pull request
Apr 24, 2015
|
Moving the changes into #110 and closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #89 - I meant to add these a while ago and simply forgot