Adding proxy support that was present in Fog back #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tyler-ball yes - I agree with your thinking - prefer |
tyler-ball
added a commit
that referenced
this pull request
May 27, 2015
Adding proxy support that was present in Fog back
|
That's looking good to me. Good idea preserving the |
|
Oh, and 👍 , heh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
\cc @fnichol @litjoco
I added a config option that defaults to
ENV['HTTP_PROXY']. @litjoco as you pointed out, there is only 1:http_proxysetting available in the AWS Ruby SDK V2, so we cannot specify a different:https_proxy. But I set up a local mitmproxy and tested that HTTPS requests worked through this proxy when specifyingENV['HTTP_PROXY']But because all the requests to AWS were actually https requests, I'm thinking of trying to first default to
ENV['HTTPS_PROXY']then falling back toENV['HTTP_PROXY']. Would this support your use case better? Or are both environment variables typically pointing to the same proxy?I'm also adding in the 0.9.2 release prep here because this is the last PR I'm waiting on for that release.