Query correct instance object for hostname fixes #148 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -201,7 +201,6 @@ def create(state) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength | |||
| wait_until_ready(server, state) | |||
|
|
|||
| info("EC2 instance <#{state[:server_id]}> ready.") | |||
| state[:hostname] = hostname(server) | |||
There was a problem hiding this comment.
The problem is that I reassign the server object passed into wait_until_ready, so the server object here refers to the first iteration of it (before we continually updated it by querying for its hostname)
…nection information instead of the new object we queried to make sure it is ready, fixes #148
tyler-ball
force-pushed
the
tball/more-bugs
branch
from
45d31a5
to
87878bf
Compare
|
👍 pulling in this branch made things function again around the connections |
tyler-ball
added a commit
that referenced
this pull request
Jun 8, 2015
Query correct instance object for hostname fixes #148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a regression where we use an old aws object to fetch connection information instead of the new object we queried to make sure it is ready
fixes #148