#394: Check subnet_filter as well when creating security group #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llibicpep Is there any way I can help in order to get this merged? |
|
@multani I don't know how do I merge this :( I didn't heard back from project maintainers so far... |
|
@tas50 Is there anything I can do to help with this PR? The behavior is similar to what can be find in a similar (sort-of) tool and is simplifying the configuration of Kitchen by not having to specify a specific VPC ID and/or subnet ID - the, more generic, filter alone should be enough. |
|
Hi, I'd love to have this merged. |
tyler-ball
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.