Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements: Security Group Search & Spot Instance Provisioning #470

Merged
merged 4 commits into from
Dec 29, 2019
Merged

Enhancements: Security Group Search & Spot Instance Provisioning #470

merged 4 commits into from
Dec 29, 2019

Conversation

bdwyertech
Copy link
Contributor

@bdwyertech bdwyertech commented Oct 11, 2019 •
edited
Loading

  • Search only for Security Groups available to a subnet's VPC
  • Support multiple matches for a single search (e.g. an Application tag which spans multiple SG's)
  • Stop masking spot instance provisioning errors
  • Fixes logic & tests for non-existent subnets & security groups

@bdwyertech
Ensure we only ever search for Security Groups within a subnet's VPC
c4fbd89 
Signed-off-by: Brian Dwyer <brian.dwyer@broadridge.com>
@bdwyertech
Fix up tests
0716c87 
Signed-off-by: Brian Dwyer <brian.dwyer@broadridge.com>
@bdwyertech bdwyertech changed the title WIP: Ensure we only ever search for Security Groups within a subnet's VPC Ensure we only ever search for Security Groups within a subnet's VPC Oct 11, 2019
@bdwyertech bdwyertech changed the title Ensure we only ever search for Security Groups within a subnet's VPC Enhancements: Security Group Search & Spot Instance Provisioning Dec 20, 2019
@tas50 tas50 merged commit 6000446 into test-kitchen:master Dec 29, 2019
@bdwyertech bdwyertech mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdwyertech @tas50