Prefer non-Beta RHEL AMIs in search; remove encoding comments #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
clintoncwolfe
commented
Aug 10, 2020
| # First do a normal version sort | ||
| super(images) | ||
| # Now sort again, shunning Beta releases. | ||
| prefer(images) { |image| !image.name.match(/_Beta-/i) } |
There was a problem hiding this comment.
"RHEL-7.9_HVM_BETA-20200422-x86_64-0-Hourly2-GP2"
"RHEL-7.8_HVM_GA-20200225-x86_64-1-Hourly2-GP2"
"RHEL-7.4_HVM_Beta-20170518-x86_64-1-Hourly2-GP2"
Are some examples of the strings to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When searching for RHEL AMIs, this change alters the search sort so that Beta AMIs are sorted after non-Beta (GA) AMIs. This has the effect of making it so that searches for
rhel-7will return RHEL 7.8 rather than RHEL 7.9 Beta, which is the expected behavior.To obtain RHEL 7.9, search explicitly for
rhel-7.9- that will cause all search results to be Beta, in which case this search sort change will have no effect.Also includes a drive-by Chefstyle update for removing the encoding comments, on a separate commit.
Issues Resolved
Fixes #505
Closes chef/chef-workstation#1410
Check List