Add support for specifying SSH key type to be generated #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated AL2022+ is based on Fedora 35 which only supports ed25519 out of the box
9 tasks
KSerrania
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Jun 2, 2022
Adds Ubuntu 22.04 x64 tests to kitchen. Modifies the test suites generation to automatically detect whether an rsa, ed25519, or the default key created by kitchen, should be used, depending on the target platforms. Renames some EC2 driver variables for consistency. Note: Ubuntu 22.04 arm64 tests can be added once test-kitchen/kitchen-ec2#583 is merged and released (to support ed25519 key creation).
|
@bdwyertech Can you make sure to get this into the docs in the main TK repo? |
Done @tas50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AL2022+ is based on Fedora 35 which only supports ed25519 out of the box
This exposes the key type passed to the AWS API as optional parameter, aws_ssh_key_type.
Packer added support for same via hashicorp/packer-plugin-amazon#179
Issues Resolved
Type of Change
Our release process assumes you are using Conventional Commit messages.
The most important prefixes you should have in mind are:
_fix_: which represents bug fixes, and correlates to a SemVer patch._feat_: which represents a new feature, and correlates to a SemVer minor._feat!_:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.If you have not included a conventional commit message this can be fixed on merge.
Check List