Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the regression after changes in 23f4d945 #99

Merged
merged 1 commit into from
Apr 21, 2015

Conversation

mumoshu
Copy link

@mumoshu mumoshu commented Feb 17, 2015

Hi,

Thanks for developing the great software :)

I have a fix for the regression in kitchen-ec2 on the master branch, which has occured after 23f4d94 (more specifically, the change in this line).

The regression is causing every kitchen test run eventually fails while trying to connect the newly created EC2 instance when you provided a value for the interface configuration parameter.

For instance, when you provided the value public for interface, kitchen test fails with the failure message:

>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: Failed to complete #create action: [undefined method `public' for #<Fog::Compute::AWS::Server:0x000000041bc430>]
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration

…en test` eventually fail when you provided a value for the `interface` configuration parameter.

The failure message is:

>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: Failed to complete #create action: [undefined method `public' for #<Fog::Compute::AWS::Server:0x000000041bc430>]
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration

See also:

test-kitchen@23f4d94#diff-c5498dad76244656522b77033980c6a6R238
@tyler-ball
Copy link
Contributor

Thanks for the catch! Better tests are next on my list, so this doesn't happen in the future.

tyler-ball added a commit that referenced this pull request Apr 21, 2015
Fix the regression after changes in 23f4d94
@tyler-ball tyler-ball merged commit 2ea5bb8 into test-kitchen:master Apr 21, 2015
@tyler-ball tyler-ball removed the ready label Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants