Allow a fuzzier match for known Bento box names. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update attempts to improve on a2ef401 which remains a workaround until the work of continuously publishing Bento boxes to Atlas is completed. The rationale and rules in the above mentioned commit remain, but now only the platform name is checked. In other words, if the platform name begins with one of the following (case-sensitive): * `centos` * `debian` * `fedora` * `freebsd` * `opensuse` * `ubuntu` then the platform is assumed to have a Bento box, hosted in the pre-determined S3 bucket. References #165 References test-kitchen/test-kitchen#707 References test-kitchen/test-kitchen#663 References chef-boneyard/chef-dk#382 References chef-boneyard/chef-dk#378
fnichol
added
Improvement
Triaged
in progress
Accepted
Developing
Reviewing
and removed
in progress
Triaged
Accepted
Developing
labels
|
👍 |
fnichol
added a commit
that referenced
this pull request
May 7, 2015
Allow a fuzzier match for known Bento box names.
This was referenced May 7, 2015
|
@fnichol 💯 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update attempts to improve on
a2ef401 which remains a workaround
until the work of continuously publishing Bento boxes to Atlas is
completed.
The rationale and rules in the above mentioned commit remain, but now
only the platform name is checked. In other words, if the platform name
begins with one of the following (case-sensitive):
centosdebianfedorafreebsdopensuseubuntuthen the platform is assumed to have a Bento box, hosted in the
pre-determined S3 bucket.
References #165
References test-kitchen/test-kitchen#707
References test-kitchen/test-kitchen#663
References chef-boneyard/chef-dk#382
References chef-boneyard/chef-dk#378