Update cookbook to current development practices

[jtimberman]

This commit modernizes the cookbook in a number of ways

• Pass rubocop
• Pass foodcritic
• Convert from minitest-chef-handler to Serverspec
• Update the Kitchen configuration

More detail is provided to summarize the changes:

• Use chef_zero because this cookbook supports data bags and that is
  easier to support tests with zero than with solo
• Update the platform versions to current releases (centos 5.11/6.6/7.1
  debian 7.8, ubuntu 14.04)
• Add fedora-21
• Remove EOL unsupported platform versions (ubuntu 10.04, 13.04)
• Move attribute setting from dnsmasq_test recipe to kitchen config
• Update supermarket source in Berksfile
• Use single quotes for attribute keys instead of double quotes or symbols
• Remove long description from metadata because it's not needed for
  anything and reads in the entire readme
• Add rubocop configuration to ignore hash rockets and line length
• Resolve several findings for Rubocop
• Use inline if statements for recipe inclusion
• Ignore FC023, because we don't want to have the resource in the
  collection if tftp-root isn't enabled, use an inline conditional to
  make the resource in column 0
• Include the config recipes because otherwise they can't fix a config
  problem before chef attempts to start dnsmasq service
• use "resource_type[resource_name]" syntax for resource lookup in notifications
• remove apt cookbook from berks and kitchen, and use execute resource
  in dnsmasq_test recipe
• Add tests for listening ports 53, 67, and 69

The change to have the nameserver 8.8.8.8 and test for that is because DNS resolution wasn't working with 127.0.0.1, so busser couldn't even install. The default attribute value is unchanged so actual behavior is no different.

[jtimberman]

Note that the box filtering in Test Kitchen's vagrant plugin has been made fuzzier.

[cwjohnston]

Looking good. Ran into a couple of exceptions, which I believe exist under the previous testing regime as well:

• centos-5.11 platform fails verification because /sbin/chkconfig is not in path. I'll address this in a follow-up PR.
• centos-6.6 platform fails verification because /etc/dnsmasq.conf has the conf-dir directive commented out (we'll need to address this separately, see Request to uncomment "conf-dir=/etc/dnsmasq.d" in /etc/dnsmasq.conf on Cent6 #9).

[jtimberman]

Huh. I swear I tested those. Maybe I'm imagining things and live in fantasy land.

Thanks for the merge 😄 🍺 🍰!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.