Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookbook to current development practices #15

Merged
merged 3 commits into from
May 12, 2015
Merged

Update cookbook to current development practices #15

merged 3 commits into from
May 12, 2015

Commits on May 7, 2015

  1. Update cookbook to current development practices

    This commit modernizes the cookbook in a number of ways
    
    - Pass rubocop
    - Pass foodcritic
    - Convert from minitest-chef-handler to Serverspec
    - Update the Kitchen configuration
    
    More detail is provided to summarize the changes:
    
    - Use chef_zero because this cookbook supports data bags and that is
      easier to support tests with zero than with solo
    - Update the platform versions to current releases (centos 5.11/6.6/7.1
      debian 7.8, ubuntu 14.04)
    - Add fedora-21
    - Remove EOL unsupported platform versions (ubuntu 10.04, 13.04)
    - Move attribute setting from dnsmasq_test recipe to kitchen config
    - Update supermarket source in Berksfile
    - Use single quotes for attribute keys instead of double quotes or symbols
    - Remove long description from metadata because it's not needed for
      anything and reads in the entire readme
    - Add rubocop configuration to ignore hash rockets and line length
    - Resolve several findings for Rubocop
    - Use inline if statements for recipe inclusion
    - Ignore FC023, because we don't want to have the resource in the
      collection if tftp-root isn't enabled, use an inline conditional to
      make the resource in column 0
    - Include the config recipes because otherwise they can't fix a config
      problem before chef attempts to start dnsmasq service
    - use "resource_type[resource_name]" syntax for resource lookup in notifications
    - remove apt cookbook from berks and kitchen, and use execute resource
      in dnsmasq_test recipe
    - Add tests for listening ports 53, 67, and 69
    jtimberman committed May 7, 2015
    Configuration menu
    Copy the full SHA
    ad52dbd View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary cookbooks from berksfile

    We're no longer using minitest-handler, and the hosts_file cookbook is a dependency of dnsmasq so it will get picked up via `metadata`.
    jtimberman committed May 7, 2015
    Configuration menu
    Copy the full SHA
    47a8b7b View commit details
    Browse the repository at this point in the history

Commits on May 10, 2015

  1. kitchen-vagrant has fuzzy bento name matching

    - Add a Gemfile
    - Remove driver_config, kitchen-vagrant 0.18 via bundler, or chefdk
      0.5.1 is expected
    jtimberman committed May 10, 2015
    Configuration menu
    Copy the full SHA
    514584d View commit details
    Browse the repository at this point in the history